Most answers here have summed up all the scenarios and decision making process, and ultimately it is up to you to make the final decision based on your personal preferences.
Personal story: One thing that I did not mention in my post from 3 years ago is that a week after I moved to Canada, I came to know that my H-1B visa was selected in the lottery on the 4th and final attempt (company got the receipt a week after I moved). For a few days I was in two minds but really I had no choice since I had done everything necessary to move and there was no going back. Interestingly, a few months later I came to know from the lawyer that I had received a RFE and since I was no longer working there they could not respond, and therefore the application was considered abandoned.
Looking back, if I had received my Canadian offer a few weeks later and decided to stay in the US, there was no guarantee that the H-1 would have been approved (not sure what the RFE was for). In a sense the timing was just pure luck and it all happened for the good, because since 2019 I’ve never given a single thought to “visa/residency issues” while in Canada. Personally for me the peace of mind is the most important.
For those working in the field of computer science, we are lucky enough that we can keep honing our skills in any market and still be in demand in North America, work remotely etc.
As @arjun-humain aptly put it, you need to think about the pros vs cons of staying in either country, and whether you are ready to spend a few years in Canada to received the citizenship and then make the final decision and have the safety net, or take a calculated risk to stay there while reaping the benefits.